pull requests with WIP?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

pull requests with WIP?

Andreas Lobinger
Hello colleagues,

just a quick question (and maybe i just missed the memo...). Do PRs with WIP mean: work in progress? -> It's not ready, but you already can take a look and comment?

Wishing a happy day,
        Andreas
Reply | Threaded
Open this post in threaded view
|

Re: pull requests with WIP?

Jacob Quinn
Yep

On Fri, Aug 28, 2015 at 10:00 AM, Andreas Lobinger <[hidden email]> wrote:
Hello colleagues,

just a quick question (and maybe i just missed the memo...). Do PRs with WIP mean: work in progress? -> It's not ready, but you already can take a look and comment?

Wishing a happy day,
        Andreas

Reply | Threaded
Open this post in threaded view
|

Re: pull requests with WIP?

Pontus Stenetorp
> On Fri, Aug 28, 2015 at 10:00 AM, Andreas Lobinger <[hidden email]>
> wrote:
>>
>> just a quick question (and maybe i just missed the memo...). Do PRs with
>> WIP mean: work in progress? -> It's not ready, but you already can take a
>> look and comment?
>
On 28 August 2015 at 17:04, Jacob Quinn <[hidden email]> wrote:
> Yep

As a reference, these conventions are documented in CONTRIBUTING.md [1].

    Pontus

[1]: https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#contributing-to-core-functionality-or-base-libraries